drivers: remove SQLAlchemy 1.4 workaround #2168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The if_exists parameter seems to work in SQLAlchemy 2.0, so remove the has_schema check and just run DropSchema directly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2168 +/- ##
===========================================
- Coverage 86.43% 86.43% -0.01%
===========================================
Files 151 151
Lines 16395 16393 -2
===========================================
- Hits 14171 14169 -2
Misses 2224 2224 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
omad
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
The if_exists parameter seems to work
in SQLAlchemy 2.0, so remove the has_schema
check and just run DropSchema directly.
Proposed changes
Closes #xxxx
Tests added / passed
Pull Request Title will make sense in ODC Release Notes
📚 Documentation preview 📚: https://opendatacube--2168.org.readthedocs.build/en/2168/